Skip to content

129629: Add models to provide-core.ts and remove duplicates#4115

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
atmire:w2p-129629_add-models-to-provide-core-list_contribute-main
Jul 30, 2025
Merged

129629: Add models to provide-core.ts and remove duplicates#4115
tdonohue merged 2 commits intoDSpace:mainfrom
atmire:w2p-129629_add-models-to-provide-core-list_contribute-main

Conversation

@AbhinavS96
Copy link
Contributor

@AbhinavS96 AbhinavS96 commented Mar 26, 2025

References

Description

Added in all the model classes mentioned in the issue. Removed some duplicates as well. SubmissionCoarNotifyWorkspaceitemModel removed from the code base. This doesn't seem to be used and is throwing errors when added to the models.

Instructions for Reviewers

List of changes in this PR:
List models updated in provide-core.ts
SubmissionCoarNotifyWorkspaceitemModel removed

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug code task 1 APPROVAL pull request only requires a single approval to merge labels Mar 26, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Mar 26, 2025
This doesn't seem to be used anywhere and was throwing some errors.
@AbhinavS96 AbhinavS96 force-pushed the w2p-129629_add-models-to-provide-core-list_contribute-main branch from 1bbe575 to 2eb09b3 Compare March 26, 2025 17:11
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release May 19, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @AbhinavS96 ! I tested the various components that were added and found no change in behavior. Everything looks good.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Jul 30, 2025
@tdonohue tdonohue added this to the 10.0 milestone Jul 30, 2025
@tdonohue tdonohue merged commit 5015e68 into DSpace:main Jul 30, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Jul 30, 2025
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug code task

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

model classes with typedObject decorator that are missing in provide-core.ts

2 participants